Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#4412] Add WeCom sink connector. #4558

Merged
merged 6 commits into from
Nov 19, 2023

Conversation

yanrongzhen
Copy link
Contributor

@yanrongzhen yanrongzhen commented Nov 16, 2023

Fixes #4412 .

Modifications

  • Add WeCom sink connector.
  • Support for sending WeCom text message to users/organizations/tags

image

Refer to: https://developer.work.weixin.qq.com/document/path/90236

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (5a8cd37) 16.87% compared to head (9604c4c) 17.00%.

Files Patch % Lines
...ector/wecom/sink/connector/WeComSinkConnector.java 64.15% 16 Missing and 3 partials ⚠️
...esh/connector/wecom/server/WeComConnectServer.java 0.00% 6 Missing ⚠️
...nnector/wecom/config/WeComConnectServerConfig.java 0.00% 3 Missing ⚠️
...nnector/wecom/sink/config/SinkConnectorConfig.java 33.33% 2 Missing ⚠️
...h/connector/wecom/sink/config/WeComSinkConfig.java 66.66% 1 Missing ⚠️
...ector/wecom/sink/connector/SendMessageRequest.java 75.00% 1 Missing ⚠️
...ctor/wecom/sink/connector/SendMessageResponse.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4558      +/-   ##
============================================
+ Coverage     16.87%   17.00%   +0.13%     
- Complexity     1638     1659      +21     
============================================
  Files           753      761       +8     
  Lines         28740    28826      +86     
  Branches       2489     2494       +5     
============================================
+ Hits           4850     4903      +53     
- Misses        23434    23464      +30     
- Partials        456      459       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanrongzhen yanrongzhen requested a review from pandaapo November 17, 2023 03:03
pandaapo
pandaapo previously approved these changes Nov 17, 2023
@xwm1992
Copy link
Contributor

xwm1992 commented Nov 19, 2023

@yanrongzhen please solve the conflict.

# Conflicts:
#	settings.gradle
@pandaapo pandaapo merged commit ad4ecf3 into apache:master Nov 19, 2023
13 checks passed
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add WeCom(Wechat work) sink connector
3 participants